LuciferYang commented on code in PR #53054: URL: https://github.com/apache/spark/pull/53054#discussion_r2533430458
########## core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala: ########## @@ -211,6 +211,8 @@ private[deploy] class Worker( private var registerMasterFutures: Array[JFuture[_]] = null private var registrationRetryTimer: Option[JScheduledFuture[_]] = None + private[worker] var heartbeatTask: Option[JScheduledFuture[_]] = None Review Comment: The identifier marked as `[work]` seems to serve the purpose of merely being callable within test cases, right? Given that the current `WorkerSuite` already has `with PrivateMethodTester`, can we adopt the approach of using `invokePrivate` for testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
