ivoson commented on code in PR #53054:
URL: https://github.com/apache/spark/pull/53054#discussion_r2536669280
##########
core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala:
##########
@@ -852,6 +863,10 @@ private[deploy] class Worker(
cleanupThreadExecutor.shutdownNow()
metricsSystem.report()
cancelLastRegistrationRetry()
+ heartbeatTask.foreach(_.cancel(true))
Review Comment:
The `synchronized` block was introduced by
https://github.com/apache/spark/pull/9138 to avoid some race conditions in very
early implementation with some async call back...
Looks like not be necessary now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
