srielau commented on code in PR #55523:
URL: https://github.com/apache/spark/pull/55523#discussion_r3142368207
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -981,7 +995,8 @@ class Analyzer(
// This is done by keeping the catalog and namespace in `AnalysisContext`,
and analyzer will
// look at `AnalysisContext.catalogAndNamespace` when resolving relations
with single-part name.
// If `AnalysisContext.catalogAndNamespace` is non-empty, analyzer will
expand single-part names
- // with it, instead of current catalog and namespace.
+ // with it, instead of current catalog and namespace. Unqualified relation
PATH is snapshotted
+ // in `AnalysisContext.resolutionPathEntries` while resolving each view
body.
Review Comment:
Done. Changed to "will be snapshotted ... in a follow-up PR".
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -317,20 +329,22 @@ class Analyzer(
if (plan.analyzed) {
plan
} else {
+ def runAnalysis(): LogicalPlan = HybridAnalyzer.fromLegacyAnalyzer(
+ legacyAnalyzer = this, tracker = tracker).apply(plan)
+ def runWithConf(): LogicalPlan = sessionConf match {
+ case Some(c) => SQLConf.withExistingConf(c) { runAnalysis() }
+ case None => runAnalysis()
+ }
Review Comment:
Done. Pushed `sessionConf` wrapping into `executeSameContext` so both
`execute` and `executeAndCheck` honor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
