srielau commented on PR #55523: URL: https://github.com/apache/spark/pull/55523#issuecomment-4320255858
All 13 self-review findings addressed in commit `4f300f70868`: 1. **Dead enum cases** -- Wired `QueryLike` from `visitDescribeRelation` 2. **Duplicated path-default logic** -- Consolidated into view-body-aware `catalogPathForError` 3. **Broken Scaladoc refs** -- All fixed to `CatalogManager.sqlResolutionPathEntries` 4. **`resolveProcedure` swallowed NonFatal** -- Now always wraps in `failedToLoadRoutineError` 5. **Redundant `||`** -- Simplified to single `isUnsupportedFunction` call 6. **No functional tests** -- Added 3 resolution tests (table order, function order, not-found) 7. **Dead `confForRoutineResolution`** -- Removed 8. **Comment about view snapshot** -- Fixed to "follow-up PR" 9. **`execute` vs `executeAndCheck` asymmetry** -- `sessionConf` wrapping in `executeSameContext` 10. **String literals** -- Replaced with `CatalogManager` constants -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
