srielau commented on PR #55523: URL: https://github.com/apache/spark/pull/55523#issuecomment-4323783195
Addressed the latest review threads in commit `99415fd4d5e` (now pushed to this PR branch): - Removed dead `UnresolvedTableOrViewSearchPathMode.TempViewOnly` and corresponding `CheckAnalysis` match arm. - Consolidated duplicated catalog-path default logic by reusing `CheckAnalysis.catalogPathForError` from `Analyzer` (`protected final`). - Fixed `AnalysisContext` comments/Scaladoc drift around `withAnalysisContext(...)` and follow-up frozen-path wiring. - Removed explicit `conf` threading from `HybridAnalyzer.fromLegacyAnalyzer`; resolver now relies on thread-local `SQLConf` under analyzer conf scope. - Aligned procedure PATH iteration semantics for unqualified names: candidate failures are treated as misses and resolution continues to later PATH entries; explicit catalog-qualified behavior is unchanged. - Added regression coverage in `ProcedureSuite`: "PATH enabled: unqualified CALL skips missing candidate and keeps searching". Focused validation run (passed): - `build/sbt 'sql/testOnly org.apache.spark.sql.connector.ProcedureSuite -- -z "PATH enabled: unqualified CALL skips missing candidate and keeps searching"'` I also replied inline on each outstanding thread with the corresponding change details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
