dongjoon-hyun commented on code in PR #56528:
URL: https://github.com/apache/spark/pull/56528#discussion_r3416990707
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveSessionImplSuite.scala:
##########
@@ -66,18 +66,20 @@ class HiveSessionImplSuite extends SparkFunSuite {
}
private def withSystemPropSession[T](allowSettingSystemProperties:
Boolean)(f: => T): T = {
+
HiveSessionImpl.setAllowSettingSystemProperties(allowSettingSystemProperties)
Review Comment:
Since this is irrelevant from `val conf`, shall we do this before `try`
body? Maybe, something like the following?
```scala
HiveSessionImpl.setAllowSettingSystemProperties(allowSettingSystemProperties)
try f finally {
sessionImpl.close()
// Restore default-deny so other tests don't inherit the relaxed state.
HiveSessionImpl.setAllowSettingSystemProperties(false)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
