dongjoon-hyun commented on code in PR #56528:
URL: https://github.com/apache/spark/pull/56528#discussion_r3417006922
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveSessionImplSuite.scala:
##########
@@ -105,6 +107,28 @@ class HiveSessionImplSuite extends SparkFunSuite {
System.clearProperty(key)
}
}
+
+ test("SPARK-57480: set:hiveconf cannot flip the legacy flag mid-session to
bypass " +
+ "the system:* gate") {
+ val key = "spark.test.HiveSessionImplSuite.bypassRegression"
+ val flagKey =
StaticSQLConf.LEGACY_HIVE_THRIFT_SERVER_ALLOW_SETTING_SYSTEM_PROPERTIES.key
+ try {
+ withSystemPropSession(allowSettingSystemProperties = false) {
+ // Before SPARK-57480, the system: gate read its toggle from the
per-session HiveConf,
Review Comment:
Let's remove `Before SPARK-57480, ` because this is meaningless because we
add a test coverage to prevent a regression and the test prefix is supposed to
mention that as you did already in line 111. This is a simple duplication
without giving any new information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
