dongjoon-hyun commented on code in PR #56528:
URL: https://github.com/apache/spark/pull/56528#discussion_r3417000070
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java:
##########
@@ -234,6 +234,20 @@ private void configureSession(Map<String, String>
sessionConfMap) throws HiveSQL
}
}
+ // SPARK-57480: resolved at server init time by SparkSQLSessionManager so
the per-session
+ // JDBC `set:` overlay cannot mutate it through `set:hiveconf:`. See
setAllowSettingSystemProperties.
+ private static volatile boolean allowSettingSystemProperties = false;
+
+ /**
+ * Configure whether `set:system:*` is permitted. Intended to be called once
at server init
+ * from SparkSQLSessionManager. Reading and writing this value is
intentionally not routed
+ * through any per-session HiveConf, since that would let a low-privilege
client mutate it
+ * via `set:hiveconf:` from the same JDBC overlay this gate is meant to
guard (SPARK-57480).
Review Comment:
Let's remove `(SPARK-57480)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
