gaogaotiantian commented on PR #56668: URL: https://github.com/apache/spark/pull/56668#issuecomment-4794167543
Actually, yes. We never use `unittest.mock` in this whole file - is it necessary to use `mock`? Honest I don't understand what's really happening with these many mocks. I'm not sure if the code owner understands. I'm a bit worried that this test was just generated by Claude Code with some random hacks and not really maintainable. Could someone explain the necessity to introduce the mock for this specific case? We also introduced a lot of the mocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
