LuciferYang commented on PR #56668: URL: https://github.com/apache/spark/pull/56668#issuecomment-4796899479
@gaogaotiantian I agree with your point and have removed the mocked test case. The mocks were originally introduced solely because the `run()` method closes the session it creates within the finally block, and there is no clean and reliable way to validate this logic using the `ReusedConnectTestCase` base test class. This test suite runs in local mode. Calling the real `stop()` method will shut down the shared Connect server used by the entire test class, rather than just terminating the current session. Please correct me if my understanding is incorrect. Additionally, I can add new test cases if you have better suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
