gaogaotiantian commented on PR #56668: URL: https://github.com/apache/spark/pull/56668#issuecomment-4803780627
I'm actually surprised how the `cli.py` is tested now - there's no real tests for the `cli` itself? I don't believe the utility is properly tested. For cli we should use a subprocess to call it and check the result. It could be a bit expensive? Launching a spark server takes a few seconds but that's not something we can't afford. We should do at least some integration test for it. I don't think it needs to be part of this PR, but that's something to consider for SDP contributors :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
