dongjoon-hyun commented on code in PR #57185:
URL: https://github.com/apache/spark/pull/57185#discussion_r3582706354
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -28538,14 +29281,17 @@ def kll_sketch_get_quantile_bigint(sketch:
"ColumnOrName", rank: "ColumnOrName")
Parameters
----------
sketch : :class:`~pyspark.sql.Column` or column name
- The KLL bigint sketch binary representation
+ The KLL bigint sketch binary representation.
+ A column that evaluates to a binary.
rank : :class:`~pyspark.sql.Column` or column name
- The rank value(s) to extract (between 0.0 and 1.0)
+ The rank value(s) to extract (between 0.0 and 1.0).
+ A column that evaluates to a double or array. Must be a constant.
Returns
-------
:class:`~pyspark.sql.Column`
The quantile value(s).
+ Returns a column that evaluates to a long.
Review Comment:
ArrayType case seems to be missed.
https://github.com/apache/spark/blob/233b1588b475e9c64dc10d8088baf19c1027d21c/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/kllExpressions.scala#L327-L328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
