dongjoon-hyun commented on code in PR #57185:
URL: https://github.com/apache/spark/pull/57185#discussion_r3582736823
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -17355,9 +17864,11 @@ def to_varchar(col: "ColumnOrName", format:
"ColumnOrName") -> Column:
Parameters
----------
col : :class:`~pyspark.sql.Column` or str
- Input column or strings.
+ The value to convert to a string.
+ A column that evaluates to a numeric, date, timestamp, time, or binary.
format : :class:`~pyspark.sql.Column` or str, optional
format to use to convert char values.
+ A column that evaluates to a string. Must be a constant.
Review Comment:
For both `to_char` and `to_varchar`, `Must be a constant` sounds wrong to
me. Foldable requirement is only for numeric/binary, `date/timestamp/time`
works with non-constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
