cloud-fan commented on code in PR #57185:
URL: https://github.com/apache/spark/pull/57185#discussion_r3615016350
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -25872,29 +26607,35 @@ def make_timestamp(
The year to represent, from 1 to 9999.
Required when creating timestamps from individual components.
Must be used with months, days, hours, mins, and secs.
+ A column that evaluates to an integer.
months : :class:`~pyspark.sql.Column` or column name, optional
The month-of-year to represent, from 1 (January) to 12 (December).
Required when creating timestamps from individual components.
Must be used with years, days, hours, mins, and secs.
+ A column that evaluates to an integer.
days : :class:`~pyspark.sql.Column` or column name, optional
The day-of-month to represent, from 1 to 31.
Required when creating timestamps from individual components.
Must be used with years, months, hours, mins, and secs.
+ A column that evaluates to an integer.
hours : :class:`~pyspark.sql.Column` or column name, optional
The hour-of-day to represent, from 0 to 23.
Required when creating timestamps from individual components.
Must be used with years, months, days, mins, and secs.
+ A column that evaluates to an integer.
mins : :class:`~pyspark.sql.Column` or column name, optional
The minute-of-hour to represent, from 0 to 59.
Required when creating timestamps from individual components.
Must be used with years, months, days, hours, and secs.
+ A column that evaluates to an integer.
secs : :class:`~pyspark.sql.Column` or column name, optional
The second-of-minute and its micro-fraction to represent, from 0 to 60.
The value can be either an integer like 13, or a fraction like 13.123.
If the sec argument equals to 60, the seconds field is set
to 0 and 1 minute is added to the final timestamp.
Required when creating timestamps from individual components.
Must be used with years, months, days, hours, and mins.
+ A column that evaluates to a decimal.
Review Comment:
The per-argument sweep stops here: `timezone`, `date`, and `time` below
still have no accepted-type phrase. The same omissions remain in
`try_make_timestamp`; both LTZ variants omit `timezone`, and both NTZ variants
omit `date`/`time`. Please document these as string, date, and time
respectively, matching the Catalyst `inputTypes` contracts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
