szehon-ho commented on PR #57434: URL: https://github.com/apache/spark/pull/57434#issuecomment-5052812913
Two test additions would be good (either in `AutoCdcParserSuite` or the pipeline suite): 1. Explicit `STORED AS SCD TYPE 1` combined with `TRACK HISTORY` is rejected -- currently only the implicit default-SCD1 + `TRACK HISTORY` case is covered. 2. Identifiers named after the new keywords still parse -- e.g. columns/tables named `history` and `track` (and `scd`, if the single-word `SCD` keyword suggested on the lexer is adopted) -- to guard the non-reserved classification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
