anew commented on code in PR #57434:
URL: https://github.com/apache/spark/pull/57434#discussion_r3634847539
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -2294,6 +2307,8 @@ ansiNonReserved
| ROWS
| SCHEMA
| SCHEMAS
+ | SCD_TYPE_1
Review Comment:
Good call — went a step further and reworked the lexing: SCD TYPE n is now
three separate tokens (SCD, TYPE, INTEGER_VALUE) validated in the AstBuilder,
instead of multi-word literals. That drops the odd non-reserved entries you
flagged, and as a bonus fixes the whitespace brittleness from SPARK-58270
(which can probably be closed). SCD TYPE 3 now gives a clear "Unsupported SCD
type" error too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
