ulysses-you commented on PR #58339: URL: https://github.com/apache/spark/pull/58339#issuecomment-5535056856
Thank you @cloud-fan for the review! All six items are addressed, each answered inline at its thread: - **Recheck distributions after applying partition grouping** -- keeping the give-up in `GroupPartitionsExec` per the round-6 discussion; the rationale is in the [existing thread](https://github.com/apache/spark/pull/58339#discussion_r3930476206). - **Cover keyless siblings in marker clearing** -- added in e2559cdfa65. - **Cover recursive marker normalization and validation** -- added in e2559cdfa65. - **Do not call the nested marker shape SQL-unreachable** -- the claim was wrong; e2559cdfa65 rewords the comment and adds the end-to-end SQL counterpart. - **Describe subset colocation as unproven, not impossible** -- reworded in 218a0f50620. - **Limit the reducer carry rule to key-changing reductions** -- reworded in 218a0f50620, paired with @peter-toth's finding 26: `identityGrouping` now requires `!keysChanged`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
