ulysses-you commented on PR #58339: URL: https://github.com/apache/spark/pull/58339#issuecomment-5548763148
Thank you @cloud-fan for the re-review. The two nits are fixed in 3c6b0143308 (comment wording and the `iterator` in the identity check). On **Recheck distributions after applying partition grouping**: agreed it should close, and I filed [SPARK-59272](https://issues.apache.org/jira/browse/SPARK-59272) as a standalone follow-up rather than folding a partial fix into this PR. The reasoning is in the [existing thread](https://github.com/apache/spark/pull/58339#discussion_r3939155993): a per-side `satisfies` recheck is not viable - partial clustering deliberately leaves the rebuilt children ungrouped yet value-aligned, so such a gate rejects that whole family. The fix needs a pairwise check on whether the two rebuilt children still declare the same aligned key sequence (the `alignToExpectedKeys` guarantee), reconciled with `ValidateRequirements`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
