cloud-fan commented on PR #58424:
URL: https://github.com/apache/spark/pull/58424#issuecomment-5655246778
I took another look. The direct and matching nested StringType cases are
covered, but there is still a Variant path to the same clock-dependent parser:
CAST on a VARIANT string delegates through VariantGet to an ordinary
StringType-to-TIMESTAMP cast, while castHasClockDependentStringToTimestamp sees
only the declared VariantType and returns false. I left the concrete case in
the review.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5644520952","thread_id":"conversation:5644520952","verdict_sha256":"d190214ac2e2804895c5d1f65e4b7733f0aed718c749a6516f66aee1b42f6436"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
