cloud-fan commented on PR #58424:
URL: https://github.com/apache/spark/pull/58424#issuecomment-5655247978
I rechecked the timestamp fix. It catches declared StringType sources,
including matching nested types, but CAST(VARIANT AS TIMESTAMP) is also a
supported route to the same time-only string parser: VariantGet unwraps a
runtime string and evaluates the ordinary LTZ Cast. Because the repeatability
helper sees VariantType, the rewrite still fires. I added this as a P2 finding.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5644528432","thread_id":"conversation:5644528432","verdict_sha256":"d190214ac2e2804895c5d1f65e4b7733f0aed718c749a6516f66aee1b42f6436"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
