MaxGekk commented on PR #59225: URL: https://github.com/apache/spark/pull/59225#issuecomment-5978069273
Thanks for the pointer, @david-mollitor-db. The two look complementary to me: #58841 turns a lookup-shaped CASE WHEN on a string key into a constant-size probe, so that shape never grows a method past the limit in the first place. This PR is for the general CASE WHEN, whose branches are arbitrary expressions and have to be split when they push a stage's method past HotSpot's limit. A lookup CASE that #58841 rewrites would simply never reach the split. We both touch `CaseWhen`'s codegen in `conditionalExpressions.scala` and `SQLConf.scala`, so whichever lands second takes a small merge; I'm happy to rebase onto yours if it goes first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
