MaxGekk commented on PR #59225: URL: https://github.com/apache/spark/pull/59225#issuecomment-5978069157
Thanks for the careful review, @HyukjinKwon. All four were right; addressed in 2582dfc: - `isCompiled`: dropped, it had no caller. - The `methodLimit` doc now states the criterion `chooseCode` applies: the split code is kept when it compiles and lowers the total bytecode of the methods past the limit, not when it shrinks the largest method. - The `class|interface|enum` regex is hoisted to a val beside `MethodHeader` and the others. - The `splitCallArguments` scaladoc now says that `removeFunctionsSince` removes a removed function's entry from it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
