pan3793 commented on PR #59897: URL: https://github.com/apache/spark/pull/59897#issuecomment-6594118879
**New Findings** 1. `dev/create-release/release-build.sh:696`: **Nit:** For Spark 5 with Java 8, this branch is unreachable. The preceding `JAVA_VERSION < "17.0." && SPARK_VERSION > "3.5.99"` check matches and exits with "required 17", even though 5.0 requires 21. Move the 5.0+ check before the 4.x check, or bound the 4.x check below 4.99. 2. `resource-managers/kubernetes/integration-tests/README.md:145`: **Nit:** `dev-run-integration-tests.sh` now defaults `JAVA_VERSION` to 21, but this line still documents 17. Update the documented default to match. 3. `sql/core/src/main/java/org/apache/spark/sql/execution/datasources/v2/ffi/NativeLibrary.java:46`: **Nit:** Spark now compiles for Java 21. The final FFM API still starts at Java 22, but the compile target in this sentence is stale. Update this and the same current-state references in `.github/workflows/build_and_test.yml:956`, `project/SparkBuild.scala:257`, `dev/scalastyle:36`, and `R/pkg/R/client.R:97`. **Still Open** 4. `sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:265`: **P2:** With the master default now Java 21, `Utils.isJavaVersionAtMost17` makes `testingVersions` empty, so this suite logs the Java 21 skip and passes without exercising any prior release. Select the latest release per line that supports the running JDK instead of returning an empty sequence. 5. `.github/workflows/benchmark.yml:35`: **Nit:** Removing the JDK 17 run leaves `BenchmarkBase.scala:55` treating 17 as the unsuffixed baseline. Every run this workflow can launch writes `-jdk21` or `-jdk25` results and cannot regenerate the unsuffixed JDK 17 baselines. Move the threshold to 21 and refresh or prune the result files as in the previous baseline bump. 6. `pom.xml:124`: **P3:** Java 17 remains the only runtime in local and docs containers: `binder/Dockerfile:39`, `dev/spark-test-image/docs/Dockerfile:60`, `dev/spark-test-image-util/docs/run-in-container:19`, and the `dev/spark-test-image/python-*` images. They will fail against Java 21 artifacts when used outside CI. Update them with this baseline bump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
