viirya commented on code in PR #59897: URL: https://github.com/apache/spark/pull/59897#discussion_r4450622163
########## .github/workflows/build_java17.yml: ########## @@ -23,28 +23,9 @@ on: workflow_dispatch: jobs: - run-build: - permissions: - packages: write - name: Run - uses: ./.github/workflows/build_and_test.yml + noop: Review Comment: Could this file and `build_maven_java21.yml` get a header comment like the one in `build_scala213.yml`? Without it, nothing says that the README badges and the `branch4*_scheduler.yml` dispatches (`--ref branch-4.*`) depend on these files staying on master, and they look safe to delete. ########## resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh: ########## @@ -38,7 +38,7 @@ CONTEXT= INCLUDE_TAGS="k8s" EXCLUDE_TAGS= DEFAULT_EXCLUDE_TAGS="N/A" -JAVA_VERSION="17" +JAVA_VERSION="21" Review Comment: `resource-managers/kubernetes/integration-tests/README.md:145` still says the default of `--java-version` is `17`. ########## docs/tuning.md: ########## @@ -232,7 +232,7 @@ temporary objects created during task execution. Some steps which may be useful value of the JVM's `NewRatio` parameter. Many JVMs default this to 2, meaning that the Old generation occupies 2/3 of the heap. It should be large enough such that this fraction exceeds `spark.memory.fraction`. -* Since 4.0.0, Spark uses JDK 17 by default, which also makes the G1GC garbage collector the default. Note that with +* Since 5.0.0, Spark uses JDK 21 by default, which also makes the G1GC garbage collector the default. Note that with Review Comment: This reads as if G1 became the default in 5.0. G1 has been the JVM default since JDK 9, and 21 is the minimum rather than a default Spark picks. Maybe: "Spark requires JDK 21 or later, where G1GC is the default garbage collector." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
