Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44443426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -120,14 +133,26 @@ trait CheckAnalysis {
case e => e.children.foreach(checkValidAggregateExpression)
}
- def checkValidGroupingExprs(expr: Expression): Unit =
expr.dataType match {
- case BinaryType =>
- failAnalysis(s"binary type expression ${expr.prettyString}
cannot be used " +
- "in grouping expression")
- case m: MapType =>
- failAnalysis(s"map type expression ${expr.prettyString}
cannot be used " +
- "in grouping expression")
- case _ => // OK
+ def checkValidGroupingExprs(expr: Expression): Unit = {
+ expr.dataType match {
+ case BinaryType =>
+ failAnalysis(s"binary type expression
${expr.prettyString} cannot be used " +
+ "in grouping expression")
+ case a: ArrayType =>
+ failAnalysis(s"array type expression
${expr.prettyString} cannot be used " +
+ "in grouping expression")
+ case m: MapType =>
+ failAnalysis(s"map type expression ${expr.prettyString}
cannot be used " +
+ "in grouping expression")
+ case _ => // OK
--- End diff --
We should also check UDT and types inside StructType
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
