Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44451436
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Stddev.scala
---
@@ -48,29 +50,26 @@ abstract class StddevAgg(child: Expression) extends
DeclarativeAggregate {
override def dataType: DataType = resultType
- // Expected input data type.
- // TODO: Right now, we replace old aggregate functions (based on
AggregateExpression1) to the
- // new version at planning time (after analysis phase). For now,
NullType is added at here
- // to make it resolved when we have cases like `select stddev(null)`.
- // We can use our analyzer to cast NullType to the default data type of
the NumericType once
- // we remove the old aggregate functions. Then, we will not need
NullType at here.
- override def inputTypes: Seq[AbstractDataType] =
Seq(TypeCollection(NumericType, NullType))
+ override def inputTypes: Seq[AbstractDataType] =
Seq(TypeCollection(NumericType))
--- End diff --
Is the NumericType still needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
