Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44454907
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -525,21 +526,14 @@ class Analyzer(
case u @ UnresolvedFunction(name, children, isDistinct) =>
withPosition(u) {
registry.lookupFunction(name, children) match {
- // We get an aggregate function built based on
AggregateFunction2 interface.
- // So, we wrap it in AggregateExpression2.
- case agg2: AggregateFunction2 =>
AggregateExpression2(agg2, Complete, isDistinct)
- // Currently, our old aggregate function interface
supports SUM(DISTINCT ...)
- // and COUTN(DISTINCT ...).
- case sumDistinct: SumDistinct => sumDistinct
- case countDistinct: CountDistinct => countDistinct
- // DISTINCT is not meaningful with Max and Min.
- case max: Max if isDistinct => max
- case min: Min if isDistinct => min
- // For other aggregate functions, DISTINCT keyword is not
supported for now.
- // Once we converted to the new code path, we will allow
using DISTINCT keyword.
- case other: AggregateExpression1 if isDistinct =>
- failAnalysis(s"$name does not support DISTINCT keyword.")
- // If it does not have DISTINCT keyword, we will return it
as is.
+ // DISTINCT is not meaningful for a Max or a Min.
+ case max: Max if isDistinct =>
+ AggregateExpression(max, Complete, isDistinct = false)
+ case min: Min if isDistinct =>
+ AggregateExpression(min, Complete, isDistinct = false)
+ // We get an aggregate function, we need to wrap it in an
AggregateExpression.
+ case agg2: AggregateFunction => AggregateExpression(agg2,
Complete, isDistinct)
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
