Github user ygcao commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r46763785
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -520,7 +537,7 @@ class Word2VecModel private[spark] (
* @return array of (word, cosineSimilarity)
*/
@Since("1.1.0")
- def findSynonyms(vector: Vector, num: Int): Array[(String, Double)] = {
+ def findSynonyms(vector: Vector, num: Int, norm: Boolean):
Array[(String, Double)] = {
--- End diff --
will add java doc to explain it.
for backward compatibility, I can add default value in this function
instead of the newly introduced one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
