Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-162253645
Hi Sean, thanks for the comment. Sorry for not notice the title requirement
for the pull request. I did check the guideline, but didn't get time to check
each line of it.
As to the style, I'm pretty much following existing code, could you be more
specific about what you found violated the style guide?
As to the distance function, agreed that separation is preferred. since
cosineSimilarity is already in place in the class, I added more in place just
to minimize my footprint of changes. If you can point out any existing class
for placing those functions, that'll be great. I don't mind to add a new class
just for distance functions, that means bigger changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
