Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10152#discussion_r46811287
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -534,8 +588,13 @@ class Word2VecModel private[spark] (
// Need not divide with the norm of the given vector since it is
constant.
val cosVec = cosineVec.map(_.toDouble)
var ind = 0
+ var vecNorm = 1f
+ if (norm)
+ vecNorm = blas.snrm2(vectorSize, fVector, 1)
--- End diff --
@ygcao this is actually a good catch but I believe is covered by
[SPARK-7617](https://issues.apache.org/jira/browse/SPARK-7617) and #6245.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
