Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r49227485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -344,6 +344,59 @@ class Analyzer(
}
}
+ def buildRightChild4Deduplication (left: LogicalPlan, right:
LogicalPlan): LogicalPlan = {
--- End diff --
extra space. Also I'm not a huge fan of `4`. How about `dedupRight` with
some scala doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
