Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10630#issuecomment-170189804
In this update, the code changes include
- Fixed a bug in `Range` by inheriting the trait `MultiInstanceRelation`.
- Added a de-duplication resolution for all the binary nodes: `Except`,
`Union` and `Co-Group`, besides `Intersect` and `Join`.
- Added a new function `duplicateResolved` for all the binary nodes.
- Improved the analysis exception message when failure to resolve
conflicting references
- Resolved all the other comments.
The analysis procedure is kind of tricky. I am unable to directly include
`duplicateResolved` into `childrenResolved`. `resolve` is lazy evaluated. The
resolution procedure need to follow the order: children at first, then itself,
and then deduplicate the attributes' expression IDs in tis children.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
