Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10630#discussion_r49239389
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -116,7 +116,18 @@ case class Union(left: LogicalPlan, right: 
LogicalPlan) extends SetOperation(lef
       }
     }
     
    -case class Intersect(left: LogicalPlan, right: LogicalPlan) extends 
SetOperation(left, right)
    +case class Intersect(left: LogicalPlan, right: LogicalPlan) extends 
SetOperation(left, right) {
    +  def duplicateResolved: Boolean = 
left.outputSet.intersect(right.outputSet).isEmpty
    +
    +  // Intersect is only resolved if they don't introduce ambiguous 
expression ids,
    +  // since it will be converted to semi Join by optimizer.
    --- End diff --
    
    Will update the comments in the code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to