Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11989#discussion_r58725975
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -422,6 +422,13 @@ class RandomForestSuite extends SparkFunSuite with
MLlibTestSparkContext {
checkFeatureSubsetStrategy(numTrees = 1, "log2",
(math.log(numFeatures) / math.log(2)).ceil.toInt)
checkFeatureSubsetStrategy(numTrees = 1, "onethird", (numFeatures /
3.0).ceil.toInt)
+ checkFeatureSubsetStrategy(numTrees = 1, "0.1", (0.1 *
numFeatures).ceil.toInt)
--- End diff --
Hi @MLnick That might be because of the repetitive lines to copy around. I
consolidated the test cases so that it is easier to track what are covered. Let
me know if additional test cases are needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
