Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12491#discussion_r60173022
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -159,7 +159,9 @@ private[classification] trait LogisticRegressionParams
extends ProbabilisticClas
@Since("1.2.0")
@Experimental
class LogisticRegression @Since("1.2.0") (
- @Since("1.4.0") override val uid: String)
+ @Since("1.4.0") override val uid: String,
+ @Since("2.0.0") val numFeatures: Int = 0,
--- End diff --
Why are we adding these vals here? Where do they get set from? Are they
needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
