Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12491#issuecomment-211729265
Thanks for taking the initiative on this PR - at first glance it seems like
this approach might not quite work but its easier to tell with some tests -
could you add a test case and run it locally? You add your test in
LogisticRegressionSuite.scala for the scala test. As well you may find the
linter tools ./dev/lint-scala & ./dev/lint-python to be useful :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
