Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12491#discussion_r60247254
  
    --- Diff: python/pyspark/ml/classification.py ---
    @@ -123,7 +123,8 @@ def __init__(self, featuresCol="features", 
labelCol="label", predictionCol="pred
         def setParams(self, featuresCol="features", labelCol="label", 
predictionCol="prediction",
                       maxIter=100, regParam=0.0, elasticNetParam=0.0, 
tol=1e-6, fitIntercept=True,
                       threshold=0.5, thresholds=None, 
probabilityCol="probability",
    -                  rawPredictionCol="rawPrediction", standardization=True, 
weightCol=None):
    +                  rawPredictionCol="rawPrediction", standardization=True, 
weightCol=None,
    +                  numFeatures=0, numClasses=0):
    --- End diff --
    
    ```numFeatures``` and ```numClasses``` should not params which can be set 
by users.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to