Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62939126
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -109,6 +128,27 @@ public static void deleteRecursively(File file) throws
IOException {
}
}
+ private static void deleteRecursivelyUsingUnixNative(File file) throws
IOException {
+ final ProcessBuilder builder = new ProcessBuilder("rm", "-rf",
file.getAbsolutePath());
+ Process process = null;
+ int exitCode = -1;
+
+ try {
+ process = builder.start();
+ exitCode = process.waitFor();
--- End diff --
When you create a process, you should always consume the input and error
streams. Otherwise, when the underlying buffer is full, `waitFor` will be
blocked forever. See Hadoop's Shell codes for example:
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java#L905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
