Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13042#discussion_r62997972 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java --- @@ -109,6 +129,40 @@ public static void deleteRecursively(File file) throws IOException { } } + private static void deleteRecursivelyUsingUnixNative(File file) throws IOException { + final ProcessBuilder builder = new ProcessBuilder("rm", "-rf", file.getAbsolutePath()); + Process process = null; + int exitCode = -1; + + try { + // Merge error stream of the process with its stdout + // Later stdout to be consumed using {@link Process#getInputStream()} + builder.redirectErrorStream(true); + + process = builder.start(); + + // In order to avoid deadlocks, consume the stdout (and stderr) of the process + final BufferedInputStream in = new BufferedInputStream(process.getInputStream()); --- End diff -- This works, but in Java 7 can we just redirect to `new File("/dev/null")` because we know this is a Unix OS? Might be simpler. PS I don't think we generally put `final` on vars unless it's necessary.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org