Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62960246
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -109,6 +128,27 @@ public static void deleteRecursively(File file) throws
IOException {
}
}
+ private static void deleteRecursivelyUsingUnixNative(File file) throws
IOException {
+ final ProcessBuilder builder = new ProcessBuilder("rm", "-rf",
file.getAbsolutePath());
+ Process process = null;
+ int exitCode = -1;
+
+ try {
+ process = builder.start();
+ exitCode = process.waitFor();
--- End diff --
@zsxwing : Good catch. I am not going to use Hadoop's ShellCommandExecutor
as it will lead to additional dependency for this small thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
