Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13704#discussion_r70193070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -479,7 +479,7 @@ case class Cast(child: Expression, dataType: DataType)
extends UnaryExpression w
case DoubleType => castToDoubleCode(from)
case array: ArrayType =>
- castArrayCode(from.asInstanceOf[ArrayType].elementType,
array.elementType, ctx)
+ castArrayCode(from.asInstanceOf[ArrayType], array, ctx)
--- End diff --
how about we move this into another PR? I think the main purpose of this PR
is to eliminate the unnecessary Cast
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
