Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13704#discussion_r70199583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2018,6 +2018,8 @@ class Analyzer(
fail(child, DateType, walkedTypePath)
case (StringType, to: NumericType) =>
fail(child, to, walkedTypePath)
+ case (from: ArrayType, to: ArrayType) if !from.containsNull =>
--- End diff --
I will try improving the `SimplifyCasts` rule to force to eliminate the
cast from non-element-nullable array to nullable ones. I do not understand the
following. Will it be automatically done by improving the `SimplifyCasts` or do
we need to improve another rule?
> "we can handle map too"
I will add unit tests for it. I think that it is good to add a benchmark to
show degree of improvements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
