Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13704#discussion_r70194231 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2018,6 +2018,8 @@ class Analyzer( fail(child, DateType, walkedTypePath) case (StringType, to: NumericType) => fail(child, to, walkedTypePath) + case (from: ArrayType, to: ArrayType) if !from.containsNull => --- End diff -- How about we improve the `SimplifyCasts` rule, to eliminate the cast from non-element-nullable array to nullable ones? And we can handle map too. Then we can add unit tests for it, instead of adding a benchmark. I think benchmark is unnecessary for this case, removing a `Cast` is definitely faster.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org