Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532409
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -36,11 +40,19 @@ case object Descending extends SortDirection {
override def sql: String = "DESC"
}
+case object NullFirst extends NullOrdering{
+ override def sql: String = "NULLS FIRST"
+}
+
+case object NullLast extends NullOrdering{
+ override def sql: String = "NULLS LAST"
+}
+
/**
* An expression that can be used to sort a tuple. This class extends
expression primarily so that
* transformations over expression will descend into its child.
*/
-case class SortOrder(child: Expression, direction: SortDirection)
+case class SortOrder(child: Expression, direction: SortDirection,
nullOrder: NullOrdering = null)
--- End diff --
I am not really against default parameters, but we typically do not do
this. How many LOC would you have to change not to have a default parameter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
