Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78474538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -253,6 +266,7 @@ class InMemoryCatalog(
throw new SparkException(s"Unable to rename table $oldName to
$newName as failed " +
s"to rename its directory $oldDir", e)
}
+ oldDesc.table = oldDesc.table.withNewStorage(locationUri =
Some(newDir.toUri.toString))
--- End diff --
We can hide the all hive specific details in HiveExternalCatalog? I see
there is many code place where we try to add a locationUri for managed table.
It doesn't seems necessary if the locationUri can be deduced from table name.
We can always do some conversion in HiveExternalCatalog to change
CatalogTable to hive understandable catalog.
```
private def saveTableIntoHive(tableDefinition: CatalogTable,
ignoreIfExists: Boolean): Unit = {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
