Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r78493048 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -204,13 +194,21 @@ case class CreateDataSourceTableAsSelectCommand( case None => data } + val tableWithPath = if (table.tableType == CatalogTableType.MANAGED) { + table.withNewStorage( + locationUri = Some(sessionState.catalog.defaultTablePath(table.identifier))) --- End diff -- This pattern: ``` val tableWithPath = if (table.tableType == CatalogTableType.MANAGED) { table.withNewStorage( locationUri = Some(sessionState.catalog.defaultTablePath(table.identifier))) ``` appears twice, may be we should create a util method in class CatalogTable?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org