Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r78493170 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -204,13 +194,21 @@ case class CreateDataSourceTableAsSelectCommand( case None => data } + val tableWithPath = if (table.tableType == CatalogTableType.MANAGED) { + table.withNewStorage( + locationUri = Some(sessionState.catalog.defaultTablePath(table.identifier))) + } else { + table + } + // Create the relation based on the data of df. val dataSource = DataSource( sparkSession, className = provider, - partitionColumns = table.partitionColumnNames, - bucketSpec = table.bucketSpec, - options = optionsWithPath) + partitionColumns = tableWithPath.partitionColumnNames, + bucketSpec = tableWithPath.bucketSpec, + paths = tableWithPath.storage.locationUri.toSeq, --- End diff -- ``` tableWithPath.storage.locationUri ``` This patterns also appears multiple times. Maybe create a helper method in class CatalogTable called location? ``` def location: Option[String] = this.storage.locationUri ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org