Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15319#discussion_r84649904
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2678,4 +2678,45 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
           }
         }
       }
    +
    +  test("SPARK-17733 InferFiltersFromConstraints rule never terminates for 
query") {
    --- End diff --
    
    Given that you already have a unit test for cases like these, how about we 
remove this now? This test was randomly generated to catch issues like this and 
in its current form, it isn't very obvious how this query has anything to do 
with `InferFiltersFromConstraints`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to