Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89695627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -405,10 +406,11 @@ case class WrapOption(child: Expression, optType:
DataType)
* A place holder for the loop variable used in [[MapObjects]]. This
should never be constructed
* manually, but will instead be passed into the provided lambda function.
*/
-case class LambdaVariable(value: String, isNull: String, dataType:
DataType) extends LeafExpression
+case class LambdaVariable(value: String, isNull: String, dataType:
DataType,
+ valueNullable: Boolean = true) extends LeafExpression
with Unevaluable with NonSQLExpression {
- override def nullable: Boolean = true
+ override def nullable: Boolean = valueNullable
override def genCode(ctx: CodegenContext): ExprCode = {
ExprCode(code = "", value = value, isNull = isNull)
--- End diff --
good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
