Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89718035 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -177,9 +177,10 @@ case class Invoke( functionName: String, dataType: DataType, arguments: Seq[Expression] = Nil, - propagateNull: Boolean = true) extends InvokeLike { + propagateNull: Boolean = true, + returnNullable : Boolean = true) extends InvokeLike { - override def nullable: Boolean = true + override def nullable: Boolean = targetObject.nullable || returnNullable --- End diff -- What do you think the behavior of `Invoke` when `returnNullable == false && needNullCheck == true`? IMO, `returnNullable` is for the calling method itself, not for `Invoke`. I think there will be the case that we want to propagate null if the method won't return a null value.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org